Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAQ.rst : Adding information about missing test. #591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FAQ.rst : Adding information about missing test. #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Help/FAQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ our master branch. Right now we use 7 of those checks:
it all documented
`here <http://api.coala.io/en/latest/Developers/Review.html>`_.

- **review/gitmate/manual/pr** This is a manual process in which the pull request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (81 > 79)

Origin: LineLengthBear, Section: docs.

can be reviewed by any coala member. Once the pull request is reviewed and
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpx3uh_vlp/Help/FAQ.rst
+++ b/tmp/tmpx3uh_vlp/Help/FAQ.rst
@@ -137,7 +137,7 @@
   `here <http://api.coala.io/en/latest/Developers/Review.html>`_.
 
 - **review/gitmate/manual/pr** This is a manual process in which the pull request
-  can be reviewed by any coala member. Once the pull request is reviewed and 
+  can be reviewed by any coala member. Once the pull request is reviewed and
   approved, it is ready to be merged into the master branch. Post approval, it will 
   be labeled with a ``process`` label marked as ``approved``.

approved, it is ready to be merged into the master branch. Post approval, it will
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpx3uh_vlp/Help/FAQ.rst
+++ b/tmp/tmpx3uh_vlp/Help/FAQ.rst
@@ -138,7 +138,7 @@
 
 - **review/gitmate/manual/pr** This is a manual process in which the pull request
   can be reviewed by any coala member. Once the pull request is reviewed and 
-  approved, it is ready to be merged into the master branch. Post approval, it will 
+  approved, it is ready to be merged into the master branch. Post approval, it will
   be labeled with a ``process`` label marked as ``approved``.
 
 - **codecov/project** This one checks whether all your code is being tested. We

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (84 > 79)

Origin: LineLengthBear, Section: docs.

be labeled with a ``process`` label marked as ``approved``.

- **codecov/project** This one checks whether all your code is being tested. We
cannot merge anything that may not work or may broke somewhere, so to avoid
obvious bugs we use this. To fix it, write doctests or unittests for your
Expand Down