-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates year in footer #586
base: master
Are you sure you want to change the base?
Conversation
Year in footer updates automatically. Fixes coala#582
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CalciumCat, you've done good work but you started working on an issue which wasn't assigned to you. This is against the organization policy.
Also, I've seen you requested to work on the issue but make sure not to submit a Pull Request/start working on the issue until a maintainer actually assigns the issue to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look okay, but once you are assigned you might also want to change the commit message according to the commit guidelines, especially the commit header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, another PR by @sambhavkaul has been made.
So this is a duplicate.
@@ -49,9 +50,11 @@ | |||
# The master toctree document. | |||
master_doc = 'index' | |||
|
|||
# General information about the project. | |||
# General information about the project. | |||
# Copyright year updated automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unnecessary.
Year in footer updates automatically. Fixes #582
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!