Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install.rst: Add link to bash/zsh auto-completion #431

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

saurabhraj1896
Copy link
Contributor

@saurabhraj1896 saurabhraj1896 commented Mar 30, 2017

This link explains users about setting-up
tab-completion for coala arguements and bear names.

Closes #386

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Copy link
Member

@supergr35 supergr35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message, I think that you could make a couple edits:

explains users about setting-up tab-completion

turns into

shows users how to set up autocompletion

and
arguements -> arguments
Other than these things this looks pretty good.

@@ -285,6 +285,13 @@ For x86 python or for x64 python:

Replace "XXX" with the ClangSharp version you received from nuget.

Shell-autocompletion support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this could be Shell-Autocompletion Support as it follows the style of the rest of the guide.


If you are a bash/zsh user , checkout the
`guide <http://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`
for setting-up tab-completion for coala arguements and bear names.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab-completion -> autocompletion (make this change in the commit body and shortlog as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supergr35 do i need to squash my last commit with this new commit(tab-completion -> autocompletion) or do separate commit for that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean to say that do i need to do separate commit apart from last commit or just amend my last commit?


If you are a bash/zsh user , checkout the
`guide <http://docs.coala.io/en/latest/Users/Shell_Autocompletion.html>`
for setting-up tab-completion for coala arguements and bear names.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting-up-> setting up

@saurabhraj1896
Copy link
Contributor Author

review @supergr35

@supergr35
Copy link
Member

ack 9011cf9

----------------------------

If you are a bash/zsh user , checkout the
``guide`` (https://docs.coala.io/en/latest/Users/Shell_Autocompletion.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link the text to the url..

This link shows users how to set up
autocompletion for coala arguments and bear names.

Closes coala#386
@aptrishu
Copy link
Member

aptrishu commented Apr 4, 2017

ack 3dd9401

@aptrishu
Copy link
Member

aptrishu commented Apr 4, 2017

@rultor merge

@rultor
Copy link

rultor commented Apr 4, 2017

@rultor merge

@aptrishu OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3dd9401 into coala:master Apr 4, 2017
@rultor
Copy link

rultor commented Apr 4, 2017

@rultor merge

@aptrishu Done! FYI, the full log is here (took me 1min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add link to bash/zsh autocompletion in installation guide
6 participants