Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements.txt: Use most recent IGitt version #640

Merged
merged 2 commits into from
Oct 26, 2018
Merged

requirements.txt: Use most recent IGitt version #640

merged 2 commits into from
Oct 26, 2018

Conversation

sks444
Copy link
Member

@sks444 sks444 commented Oct 25, 2018

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

jayvdb
jayvdb requested changes Oct 25, 2018
View reviewed changes
setup.cfg Outdated
@@ -18,6 +18,7 @@ addopts =
-p no:logging
--color=yes
--doctest-glob=*.rst
--doctest-modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change are the ones which are blocked #616

please remove, and make sure CI is green

@jayvdb
Copy link
Member

jayvdb commented Oct 26, 2018

ack a92608a b9d569d

@jayvdb
Copy link
Member

jayvdb commented Oct 26, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot gitmate-bot merged commit b9d569d into coala:master Oct 26, 2018
@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvdb jayvdb jayvdb approved these changes

Assignees
No one assigned
Labels
process/approved size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sks444 @jayvdb @gitmate-bot