Makman2/more issue formats #297
Conversation
... to be defined inside code easily by using custom parser functions.
... of the form `#12`.
Makman2
force-pushed
the
Makman2/more-issue-formats
branch
from
69cdbe7
to
cb09d1f
Compare
|
Hmm it seems to be more complicated than expected to get the room name... |
plugins/labhub.py
Outdated
| roomname_match = re.fullmatch( | ||
| roomname_rgx, msg.frm.room.idd, re.IGNORECASE) | ||
|
|
||
| if roommatch is None: |
There was a problem hiding this comment.
You mean roomname_match, right?
plugins/labhub.py
Outdated
| if roommatch is None: | ||
| return None | ||
|
|
||
| return roommatch.group(1), roommatch.group(2), m.group(1) |
There was a problem hiding this comment.
There is no m in this scope :/
There was a problem hiding this comment.
ah yeah this has to be the very first match variable from above, will correct it :3
(you already see that my tests aborted above because accessing the room name raised an exception :D)
plugins/labhub.py
Outdated
|
|
||
| roomname_rgx = r'(.+?)/(.+)' | ||
| roomname_match = re.fullmatch( | ||
| roomname_rgx, msg.frm.room.idd, re.IGNORECASE) |
There was a problem hiding this comment.
msg.frm.room.uri instead of msg.frm.room.idd
There was a problem hiding this comment.
However, for uri, you'll find that many coala room URIs are of coala/coala/<name> type
There was a problem hiding this comment.
is that for custom rooms? Or do even repo-related rooms have a name like e.g. coala/coala/coala-bears?
There was a problem hiding this comment.
Also, room itself does not exist inside the tests, I'm not sure how to mock it correctly, as this field seems to be backend-dependent.
... of the form `#1234`. Closes #167
Makman2
force-pushed
the
Makman2/more-issue-formats
branch
from
cb09d1f
to
b67c4d5
Compare
... to separate the import section from code with 2 blank lines.
No description provided.