Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add coala-ci checks #435

Closed
Makman2 opened this issue Dec 1, 2017 · 8 comments
Closed

CI: Add coala-ci checks #435

Makman2 opened this issue Dec 1, 2017 · 8 comments
Assignees
@bhavishyagopesh
Labels
area/ci difficulty/newcomer importance/high

Comments

@Makman2
Copy link
Member

Makman2 commented Dec 1, 2017

gitmate is behaving weird recently, we need a run of coala itself as a fallback.
@Makman2 Makman2 mentioned this issue Dec 1, 2017
Closed
@bhavishyagopesh
Copy link

@Makman2 Is this done with the current PR(#437) ?

@Makman2
Copy link
Member Author

Makman2 commented Dec 2, 2017 •
edited
Loading

No this issue is about adding a call to coala to our CI, so we don't rely only on gitmate (as it recently failed to flag issues in code recently).

@bhavishyagopesh
Copy link

@Makman2 Adding docker run coala/base coala --ci to .travis.yml would work?

@Makman2
Copy link
Member Author

Makman2 commented Dec 2, 2017

Maybe :)

bhavishyagopesh pushed a commit to bhavishyagopesh/corobo that referenced this issue Dec 2, 2017
@idealrealism
.travis.yml: Add coala-ci checks
fb87b81 
Calls `coala --ci` from CI

Closes coala#435
@bhavishyagopesh bhavishyagopesh mentioned this issue Dec 2, 2017
Closed
6 tasks
bhavishyagopesh pushed a commit to bhavishyagopesh/corobo that referenced this issue Dec 3, 2017
@idealrealism
.travis.yml: Add coala-ci checks
c43ec57 
Calls `coala --ci` from CI

Closes coala#435
bhavishyagopesh pushed a commit to bhavishyagopesh/corobo that referenced this issue Dec 3, 2017
@idealrealism
.travis.yml: Add coala-ci checks
4174114 
Calls `coala --ci` from CI

Closes coala#435
@jayvdb
Copy link
Member

jayvdb commented Dec 3, 2017

@Makman2 , I believe that travis and semaphore are both already running coala checks.

#454 (comment)

.travis.yml and .ci/semaphore.tests.sh omit GitCommitBear with sed -i.bak '/bears = GitCommitBear/d' .coafile , and that is due to a bug in coala-bears.

@Makman2
Copy link
Member Author

Makman2 commented Dec 3, 2017

Oh do you have the issue link maybe? In that case let's quickly resolve that issue and close this one ;)

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2017

@Makman2 coala/coala-bears#1037

@jayvdb
Copy link
Member

jayvdb commented Dec 9, 2017

Bug is bogus.

@jayvdb jayvdb closed this as completed Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhavishyagopesh bhavishyagopesh

Labels
area/ci difficulty/newcomer importance/high
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @Makman2 @bhavishyagopesh