Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coafile/commit section: Enhance rules (like on other coala repos) #422

Closed
Makman2 opened this issue Nov 30, 2017 · 6 comments
Closed

coafile/commit section: Enhance rules (like on other coala repos) #422

Makman2 opened this issue Nov 30, 2017 · 6 comments

Comments

@Makman2
Copy link
Member

Makman2 commented Nov 30, 2017

We are currently missing a max-shortlog-length, imperative mood check and issue reference check.

@gitmate-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @meetmangukiya.

@Makman2
Copy link
Member Author

Makman2 commented Nov 30, 2017

Seems that actually we have already the checks from the coala/coala repo, we could additionally add the issue-reference settings from coala/coala-bears.

What actually confused me was that gitmate was not complaining on this PR, where the commit violates the style rules: #404

@jayvdb
Copy link
Member

jayvdb commented Dec 1, 2017

gitmate is weird lately.
We need CI to be using coala-ci as a fallback

@yashasingh
Copy link
Member

yashasingh commented Dec 1, 2017

@Makman2 I was going through the issue and I realized that line 30, comparing with other coafiles coala-bears, coala, documentation, docker-coala-base etc and other coala repos, has commit instead of commits.

Can updating this resolve the issue? We may also include issue-reference settings from coala/coala-bears.

@Makman2
Copy link
Member Author

Makman2 commented Dec 1, 2017

@yashasingh you can file a new issue to change the section name from commits to commit (which definitely makes sense ;D), this one is a different issue.

@jayvdb I'll file a new issue for the CI-checks 👍

@Makman2
Copy link
Member Author

Makman2 commented Dec 1, 2017

--> #435

yashasingh added a commit to yashasingh/corobo that referenced this issue Dec 1, 2017
Adds the additional issue-reference settings from
coala/coala-bears.

Closes coala#422
gitmate-bot pushed a commit to yashasingh/corobo that referenced this issue Feb 1, 2018
Adds the additional issue-reference settings from
coala/coala-bears.

Closes coala#422
EverWinter23 pushed a commit to EverWinter23/corobo that referenced this issue Apr 4, 2018
Adds the additional issue-reference settings from
coala/coala-bears.

Closes coala#422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants