This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
.vscode-client: Drop vscode client #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are using this repository to place language server and coala/coala-vs-code to place the vs code client. Thus we need to remove the client from this repository and remove language server from coala/coala-vs-code after all things in this repository is ready. LGTM |
gaocegege
approved these changes
Jun 8, 2018
|
/assign @jayvdb I think we need you to merge the PR. |
|
There are still two more references to vscode-client $ git grep vscode-client
README.md:Then you should update the `./vscode-client/src/extension.ts` to make client in TCP mode.
README.md:To try it in [Visual Studio Code](https://code.visualstudio.com), open Those need to be removed to make this patch atomic. |
Drop vscode client since no component of coala-ls now is specific to or depends on VSCode.
|
Could we merge it? |
|
@gitmate-bot ff |
1 similar comment
|
@gitmate-bot ff |
|
This repo is going to be destroyed/archived and replaced with a clean rebuilt repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop vscode-client since no component of coala-ls now is specific to or depends on VSCode.