-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security/README.rst: Fix template rendering #13
base: master
Are you sure you want to change the base?
Conversation
Hey @adtac @li-boxuan , can you review out this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding a workaround. Apparently, it is rendered now. What change did you do to the file?
Files changed
tab is saying that Binary file not shown
. Maybe the file is wrongly encoded. Is it possible to change it to a normal file?
I actually just added more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub says it is a Binary file, so the diff is not shown. Can you try removing the file, then create a new rst file and paste the content? And see if it becomes a regular file. Or see if there is any other solution.
Ok, I will try to find a solution so that difference is visible |
fdb3635
to
a3d38ab
Compare
I tried to delete the previous file and paste the content of previous file to a newly created file, but then also GitHub was showing that message "Binary file not shown". And when I pushed a new file without deleting the old file then it is clearly displaying the difference. Also, Renaming the file doesn't seems to fix the problem.
I have checked out the last solution and it is working perfectly fine, the only thing is that it is divided into 2 commits. |
@li-boxuan can you help me out, what to do for now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a binary file?
Also, you could have written a good commit message.
That binary file is the original README.rst file, that GitHub is recognizing it as a binary file. That's why the any changes being made in it, aren't being displayed. To solve this issue, I found two ways that I have suggested above. We can go with any of them. The only thing is it will take 2 commits. I have implemented the first way that's why we are able to a new file README2.rst |
There was as issue with GitHub
rst
generator. The issuehas been solved by GitHub. Making a small change in file,
fixes the template rendering problem.
Fixes #10