fix(multiple): multiple small bugfixes

coactum · Sep 9, 2022 · a879d3a · a879d3a
1 parent 4e703a8
commit a879d3a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/edit.php b/edit.php
@@ -206,7 +206,7 @@
 
         // Update timemodified for base entry.
         $baseentry = $DB->get_record('margic_entries', array('margic' => $moduleinstance->id, "id" => $newentry->baseentry));
-        $baseentry->timemodified = $fromform->timecreated;
+        $baseentry->timemodified = $newentry->timecreated;
         $DB->update_record('margic_entries', $baseentry);
 
         $newentry->feedback = $entry->feedback;

diff --git a/errortypes.php b/errortypes.php
@@ -78,6 +78,10 @@
         $editedtype = $DB->get_record('margic_errortype_templates', array('id' => $edit));
     } else if ($mode == 2) { // If type is margic error type.
         $editedtype = $DB->get_record('margic_errortypes', array('id' => $edit));
+
+        if ($moduleinstance->id !== $editedtype->margic) {
+            redirect($redirecturl, get_string('errortypecantbeedited', 'mod_margic'), null, notification::NOTIFY_ERROR);
+        }
     }
 
     if ($editedtype && $mode == 2 ||

diff --git a/lang/de/margic.php b/lang/de/margic.php
@@ -104,7 +104,7 @@
 $string['currententry'] = 'Aktuelle Einträge';
 $string['oldestentry'] = 'Älteste Einträge';
 $string['lowestgradeentry'] = 'Am niedrigsten bewertete Einträge';
-$string['highestgradeentry'] = 'Am höchsten bewertete Beiträge';
+$string['highestgradeentry'] = 'Am höchsten bewertete Einträge';
 $string['editingstarts'] = 'Der Bearbeitungszeitraum beginnt am {$a}';
 $string['editingends'] = 'Der Bearbeitungszeitraum endet am {$a}';
 $string['editingended'] = 'Der Bearbeitungszeitraum endete am {$a}';