Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filesystem check for write access etc. #561

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove filesystem check for write access etc. #561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0644b21
Remove filesystem check for write access etc.
cnizzardini Oct 2, 2024
8b52e3d
cleanup
cnizzardini Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/Lib/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,31 +219,16 @@ public function getJson(): string
*/
public function setJson(string $json)
{
$message = 'Generally this value should be placed in your projects webroot directory.';

if (!str_starts_with(haystack: $json, needle: '/')) {
throw new InvalidArgumentException(
sprintf(
"Invalid json: `%s`. Value should start with a `/` and be relative to your
applications ROOT. $message",
applications ROOT. Generally this value should be placed in your projects webroot directory.",
$json
)
);
}

$path = $this->root . $json;
if ((!file_exists($path) && !is_writable($path)) || !touch($path)) {
throw new InvalidArgumentException(
sprintf(
"Invalid json: `%s`. Config value for `json` must exist on the file system. An attempt was
made to create %s, but permission was denied or the file path is bad. Either fix the file system
permissions, create the file and/or both. $message",
$json,
$path
)
);
}

$this->json = $json;

return $this;
Expand Down
Loading