Skip to content

Commit

Permalink
add support for configMap volumes (#172)
Browse files Browse the repository at this point in the history
* add support for configMap volumes

* github: use chart-testing-action v2.5.0

* github: use chart-testing-action v2.6.0

* default-chart: bump version

* pipeline: fix config

* pipeline: fix config

* pipeline: bump helm/chart-testing-action to 2.6.1

* pipeline: add debug

* pipeline: add debug

* Revert "pipeline: add debug"

This reverts commit e28298b.

* pipeline: remove undefined option
  • Loading branch information
gcavelier authored Feb 26, 2024
1 parent b4659df commit a51722e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/helm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
python-version: 3.7

- name: Set up chart-testing
uses: helm/chart-testing-action@v2.4.0
uses: helm/chart-testing-action@v2.6.1

- name: Run chart-testing (list-changed)
id: list-changed
Expand Down
2 changes: 1 addition & 1 deletion charts/default-chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 3.0.7
version: 3.0.8

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
3 changes: 3 additions & 0 deletions charts/default-chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ spec:
{{- if .secretName }}
secret:
secretName: {{ .secretName }}
{{- else if .configMapName }}
configMap:
name: {{ .configMapName }}
{{- else }}
persistentVolumeClaim:
claimName: {{ $chartName }}-{{ .name }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- $labels := include "default-chart.labels" . -}}
{{- if and .Values.persistence.enabled }}
{{- range .Values.persistence.volumes }}
{{- if not .secretName }}
{{- if not (or .secretName .configMapName) }}
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
Expand Down

0 comments on commit a51722e

Please sign in to comment.