Fix empty alarm actions (#38)

cn-terraform · Sep 19, 2024 · 48f0857 · 48f0857
1 parent eea2372
commit 48f0857
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/main.tf b/main.tf
@@ -14,10 +14,10 @@ resource "aws_cloudwatch_metric_alarm" "cpu_high" {
     ClusterName = var.ecs_cluster_name
     ServiceName = var.ecs_service_name
   }
-  alarm_actions = [
+  alarm_actions = compact([
     aws_appautoscaling_policy.scale_up_policy.arn,
     var.sns_topic_arn != "" ? var.sns_topic_arn : ""
-  ]
+  ])
   tags = var.tags
 }
 
@@ -37,10 +37,10 @@ resource "aws_cloudwatch_metric_alarm" "cpu_low" {
     ClusterName = var.ecs_cluster_name
     ServiceName = var.ecs_service_name
   }
-  alarm_actions = [
+  alarm_actions = compact([
     aws_appautoscaling_policy.scale_down_policy.arn,
     var.sns_topic_arn != "" ? var.sns_topic_arn : ""
-  ]
+  ])
   tags = var.tags
 }