Fix

unfair/model/utils.py

@@ -1721,6 +1721,7 @@ def find_bound(vals, target, min_idx, max_idx, which):
     vals must be monotonically increasing.
     """
     assert min_idx >= 0
+    assert max_idx < len(vals)
     assert max_idx >= min_idx
     assert which in {"before", "after"}
     if min_idx == max_idx:
@@ -1844,7 +1845,7 @@ def get_ack_packets(pkts):
                 data_pkts[features.ARRIVAL_TIME_FET],
                 accept_after_us,
                 0,
-                len(data_pkts),
+                len(data_pkts) - 1,
                 "before",
             )
 
@@ -1854,7 +1855,7 @@ def get_ack_packets(pkts):
                 data_pkts[features.ARRIVAL_TIME_FET],
                 accept_before_us,
                 0,
-                len(data_pkts),
+                len(data_pkts) - 1,
                 "after",
             )
 

unfair/scripts/eval.py

@@ -705,11 +705,13 @@ def calculate_maxmin_ratios(params, flw_to_pkts, flw_to_sender, sender_to_flws):
             )
         # Case 3 above.
         else:
-            assert (
+            total_sender_bneck_bps = (
                 sender_to_ratebps[smaller_sender] + sender_to_ratebps[larger_sender]
-            ) < (params["bess_bw_Mbps"] * 1e6), (
-                "Error: Sum of the sender bottlenecks "
-                "must be less than the shared bottleneck!"
+            )
+            assert total_sender_bneck_bps < (params["bess_bw_Mbps"] * 1e6), (
+                f"Error: Sum of the sender bottlenecks ({total_sender_bneck_bps} bps) "
+                "must be less than the shared bottleneck "
+                f"({params['bess_bw_Mbps'] * 1e6} bps)!"
             )
 
     # For each bottleneck situation, compare each flow's actual throughput to its
@@ -724,7 +726,7 @@ def calculate_maxmin_ratios(params, flw_to_pkts, flw_to_sender, sender_to_flws):
                 pkts[features.ARRIVAL_TIME_FET],
                 end_s * 1e6,
                 flw_to_last_cutoff_idx[flw],
-                len(pkts),
+                len(pkts) - 1,
                 "before",
             )
             tpus_bps = utils.safe_tput_bps(