Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): separate cost model and stat estimation #209

Merged
merged 3 commits into from
Nov 3, 2024
Merged

refactor(core): separate cost model and stat estimation #209

merged 3 commits into from
Nov 3, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 2, 2024 •
edited
Loading

part of #195

  • also refactors the adv-cost crate to purely support cardinality estimation
  • rewrite optimize input task to reduce dead code (which might have some effect on the plan output?)
  • use cargo run -p optd-sqlplannertest --bin planner_test_apply -- --enable-advanced-cost-model to experiment with the advanced cost model

@skyzh skyzh requested a review from jurplel November 2, 2024 00:58
jurplel
jurplel approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@jurplel jurplel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@skyzh skyzh merged commit 29647f2 into main Nov 3, 2024
1 check passed
@skyzh skyzh deleted the skyzh/separate-cost-stat branch November 3, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurplel jurplel jurplel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyzh @jurplel