Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cost): use 1000 as default table row cnt #208

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 1, 2024

Helps us generate better plans across all regression tests, otherwise row_cnt=1 does not make much sense. This also fixes NLJ within subquery unnesting test case.

Call simplify expr when applying join pushdown rules, which in the future should be done automatically in the core.

@skyzh skyzh enabled auto-merge (squash) November 1, 2024 03:26
@skyzh skyzh merged commit 4c8f4b4 into main Nov 1, 2024
1 check passed
@skyzh skyzh deleted the skyzh/base-cost-row-cnt branch November 1, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants