fix(core): improve dead-loop avoidance in OptimizeInputs (v2) #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the sequential traversal of the tasks queue (that gets quite large) with a dynamic cast for each task (which is slow), every time an OptimizeInputs runs. See cmu-db#29 for original code. This does however consume more memory.
skyzh
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OptimizeInputsTask avoids a dead-loop with a sequential traversal of a potentially long list of tasks, with a dynamic cast for each of them (see #29). This alternative uses a hashset of previously visited expressions for the same purpose, similarly to explored_group.
This is the second attempt, after #196.