Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Physical props #173

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

[WIP] Physical props #173

wants to merge 17 commits into from

Conversation

AveryQi115
Copy link
Contributor

@AveryQi115 AveryQi115 commented Apr 30, 2024

  • basic framework
  • default physical properties builder (without any constraints)
  • test default builder
  • ordering physical properties builder (Sort -> order)
  • testcases
  • code reconstruction

@AveryQi115 AveryQi115 marked this pull request as draft April 30, 2024 03:35
Signed-off-by: AveryQi115 <[email protected]>
Signed-off-by: AveryQi115 <[email protected]>
@jurplel
Copy link
Member

jurplel commented Sep 9, 2024

Why is it that we needed to incorporate the notion of a SubGroup here? I think that is non-standard...

I am predicting it may be because we are lacking separation of the phases that apply transformation rules and implementation rules?

@AveryQi115
Copy link
Contributor Author

Why is it that we needed to incorporate the notion of a SubGroup here? I think that is non-standard...

I am predicting it may be because we are lacking separation of the phases that apply transformation rules and implementation rules?

No, it’s not related to separation of transformation rules and impl rules. It’s a standard way to do this, just see calcite and cockroaches code. They both have a notion of logically equivalent and physically equivalent subset in logically equivalent set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants