-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an openImage function that can open PIL images and download from http #77
base: main
Are you sure you want to change the base?
Add an openImage function that can open PIL images and download from http #77
Conversation
Added openImage to more easily open PIL images. These images can then be manipulated by PIL library and transformed into a CMUImage like usual.
…c'sand PIL's Image type. Also made it work from the repl
This now works perfectly and passes all the tests. If merged could really help students working with images, as it's now only a matter of calling a function without having to worry about file path etc, potentially making unnecessary or at least easier to finish. It could also help in other part of cmu_graphics source code where images are being handled
I am not sure if the function needs to be translated somewhere and if it needs to be included in the import of TL;DR this function aims to expose the loadImageFromStringReference function present in shape_logic.py to the user, and to thus replace it in some way |
…e considered core and to be able to translate errors, and fixed test
I need some help on this one. The test is only failing for macOS zip install, which is weird, and I cannot test locally to debug. @schmave mind taking a quick look on this when you have the time. Also, quick mention, the other 3 PR are now ready for review. |
Hi! Thanks for contributing. I'll take a look at this! If you are currently active, would it be possible to close and reopen this PR on your end so that the checks can be ran again (the artifacts from the past run expired so that the report log cannot be accessed)? I think my permission on this repo isn't set up correctly just yet so I can't do that from my end :( |
Done! Let's see what happening now. |
Added openImage to more easily open PIL images. These images can then be manipulated by PIL library and transformed into a CMUImage like usual.