Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DQM / Validation monitoring for hltInitialStep and hltHighPtTriplet tracks in the Phase2 HLT menu #46823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 28, 2024

PR description:

Recently the Phase-2 HLT group started to review and optimize the Pixel tracks as seeds (and more) for HLT. In this context it is not unreasonable to foresee changes in that iteration as well as in the other (high pT triplet iteration) currently in use to build the final HLT tracks collection in the phase-2 menu
So it would be ideal to monitor both of them at the same time
This PR provides support for DQM and Validation for hltInitialStep and hltHighPtTriplet tracks in the Phase2 HLT menu.

PR validation:

Run the following workflow:

runTheMatrix.py -l 29834.999 --ibeos

I observe in the output of the step3 the following additional collections:

$ edmEventSize -v -a 29834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR/step3.root | grep -E 'hltInitial|hltHighPt'
recoTrackExtras_hltInitialStepTrackSelectionHighPurity__HLT. 38142.7 27737.6
recoTrackExtras_hltHighPtTripletStepTrackSelectionHighPurity__HLT. 11475 8452.3
recoTracks_hltInitialStepTrackSelectionHighPurity__HLT. 15124.2 5281.5
TrackingRecHitsOwned_hltInitialStepTrackSelectionHighPurity__HLT. 40521.9 4144.9
recoTracks_hltHighPtTripletStepTrackSelectionHighPurity__HLT. 4760.4 1833.6
TrackingRecHitsOwned_hltHighPtTripletStepTrackSelectionHighPurity__HLT. 11860.7 1581.2
uchars_hltHighPtTripletStepTrackSelectionHighPurity_QualityMasks_HLT. 307.4 292.9
floats_hltHighPtTripletStepTrackSelectionHighPurity_MVAValues_HLT. 338.4 286.5
uchars_hltInitialStepTrackSelectionHighPurity_QualityMasks_HLT. 328.7 284.5
floats_hltInitialStepTrackSelectionHighPurity_MVAValues_HLT. 448.8 278.4

Inspecting the output DQM file I see the new plots appearing for the considered collections.
An example root DQM file that can be obtained with this branch is available here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no interest in backporting (at least for the time being)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46823/42826

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • DQMOffline/Trigger (dqm)
  • Validation/RecoTrack (dqm)

@antoniovagnerini, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @VinInn, @VourMa, @cericeci, @dgulhan, @fabiocos, @felicepantaleo, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @rovere, @trocino, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a806/43134/summary.html
COMMIT: dab7cb3
CMSSW: CMSSW_15_0_X_2024-11-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46823/43134/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2024.303001DAS Error

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2024

2024.303001DAS Error

nice...

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a806/43142/summary.html
COMMIT: dab7cb3
CMSSW: CMSSW_15_0_X_2024-11-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46823/43142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3597272
  • DQMHistoTests: Total failures: 458
  • DQMHistoTests: Total nulls: 32
  • DQMHistoTests: Total successes: 3596762
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42582.282 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 7097.047 KiB HLT/Tracking
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants