Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC1] py2/3 compatibility:drop use of __future__ #46778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

see #46762

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • CondTools/DQM (dqm, db)
  • CondTools/HLT (hlt, db)
  • CondTools/L1Trigger (l1, db)
  • CondTools/SiPhase2Tracker (alca, upgrade)
  • Configuration/Geometry (upgrade, geometry)
  • Configuration/Skimming (pdmv)
  • DPGAnalysis/Skims (pdmv)
  • DQM/BeamMonitor (dqm, db)
  • Geometry/CMSCommonData (upgrade, geometry)
  • Geometry/GEMGeometry (upgrade, geometry)

@AdrianoDee, @Dr15Jones, @Martin-Grunewald, @Moanwar, @aloeliger, @antoniovagnerini, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @DickyChant, @epalencia, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @miquork, @mmusich, @perrotta, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@AnnikaStein, @JanChyczynski, @Martin-Grunewald, @PonIlya, @VinInn, @bsunanda, @fabiocos, @francescobrivio, @giovanni-mocellin, @jshlee, @martinamalberti, @missirol, @mmusich, @rsreds, @silviodonato, @slomeo, @tocheng, @vargasa, @watson-ij, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d58053/43047/summary.html
COMMIT: e920110
CMSSW: CMSSW_15_0_X_2024-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46778/43047/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 313 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3596288
  • DQMHistoTests: Total failures: 3845
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3592423
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 1 / 45 workflows

@mmusich
Copy link
Contributor

mmusich commented Nov 25, 2024

+hlt

@AdrianoDee
Copy link
Contributor

+pdmv

@antoniovagnerini
Copy link

+dqm

@aloeliger
Copy link
Contributor

+l1

@perrotta
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Nov 26, 2024

+1

@smuzaffar
Copy link
Contributor Author

@cms-sw/upgrade-l2 can you please review this?

@Moanwar
Copy link
Contributor

Moanwar commented Nov 30, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants