Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature alpaka #8

Merged
merged 62 commits into from
Jan 19, 2024
Merged

Feature alpaka #8

merged 62 commits into from
Jan 19, 2024

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Oct 31, 2023 •
edited
Loading

  • This PR uses the alpaka library to compile the source code for many different backends.
  • The compilation and setup.py will have to be rewritten using CMake, in order to make the distribution easier

@sbaldu sbaldu marked this pull request as draft October 31, 2023 14:43
@sbaldu sbaldu force-pushed the feature_alpaka branch 3 times, most recently from a5c3d11 to 91ec1bc Compare November 3, 2023 16:07
@sbaldu sbaldu marked this pull request as ready for review November 3, 2023 16:07
@waredjeb waredjeb self-assigned this Dec 12, 2023
@sbaldu sbaldu requested a review from waredjeb December 12, 2023 13:53
waredjeb
waredjeb requested changes Dec 13, 2023
View reviewed changes
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/CLUEstering.py Outdated Show resolved Hide resolved
CLUEstering/alpaka/BindingModules/Makefile Outdated Show resolved Hide resolved
CLUEstering/alpaka/CLUE/CLUEAlgoAlpaka.h Outdated Show resolved Hide resolved
CLUEstering/alpaka/CLUE/Run.h Outdated Show resolved Hide resolved
waredjeb
waredjeb reviewed Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@waredjeb waredjeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment would be to polish a bit the Makefile, other than that everything looks fine now for me

waredjeb
waredjeb requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@waredjeb waredjeb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good also for HIP, one last comment would be to add the configuration for HIP in the CLUEstering.py script to have the example for HIP as well

@sbaldu
Copy link
Collaborator Author

sbaldu commented Jan 10, 2024

Changes look good also for HIP, one last comment would be to add the configuration for HIP in the CLUEstering.py script to have the example for HIP as well

Yep, just pushed it

@sbaldu sbaldu mentioned this pull request Jan 10, 2024
Open
sbaldu and others added 16 commits January 18, 2024 14:54
@sbaldu
Start implementing the alpaka version of the algorithm
e681538
@sbaldu
Add Points and PointsAlpaka data structures
9609dab
@slanzi00 @sbaldu
[feature_alpaka] write convolutional kernels with alpaka
5be35d5
@sbaldu
Include cms VecArray in alpaka data formats
3a2443c
@sbaldu
Corrections in Points and PointsAlpaka classes
4b26373
@slanzi00 @sbaldu
Add draft of kernels for the clustering methods
2bf91e7 
Fixes in the Points data structure

Fix typo in Points
@sbaldu
Add copy/move constructors in PointsAlpaka and PointsAlpakaView
91b5da4 
Fix in the convolutional kernels
@sbaldu
Add kernel for local density
03330bb 
Fix relative paths in AlpakaCore
@sbaldu
Add header for TilesAlpaka class
06e83d3
@sbaldu
Add temporary main and data for testing
f372afa
@sbaldu
Add first draft of CLUEAlgoAlpaka class header
0dd82c6 
Fix typo in PointsAlpaka
@sbaldu
Written kernel for the search of the most energetic neighbour
eb73bbb
@slanzi00 @sbaldu
add KernelFindClusters and KernelAssignClusters
bfb971c 
Fixes in the Points classes
@sbaldu
Fix non trivial copyability in the TilesAlpaka class
353013c
@sbaldu
Write methods for CLUEAlgoAlpaka
2f376f9 
Fixes in the CLUE alpaka kernels
@sbaldu
Fix typing errors in CLUEAlgo
6bfa829
@sbaldu
Keep che number of tiles fixed and known at compile time
e49603d
@sbaldu
Update pybind submodule to sbaldu's fork, which fixes error by nvcc
76e7fac 
Cleaning
@sbaldu
Add boost and alpaka submodules
7038b8a
@sbaldu
Update paths of alpaka and boost in test makefile
9814f35
@sbaldu
Remove unneeded headers in AlpakaCore
1fb83ec
@sbaldu
Use cms::alpakatools::divide_up_by when creating working divisions
1d7f858
@sbaldu
Add CLUEAlgo member for block size and bind its setter
c602e17
@sbaldu
Fix wrong include
23d2c47
@sbaldu
Change block_size to parameter for mainRun
b80ae4f
@sbaldu
Formatting
b099674
@sbaldu
Use endswith in _read_string
f8585c7
@sbaldu
Clean alpaka version of CLUEstering.py
4b8e5e8
@sbaldu
Implement method for listing devices from python
4ede444
@sbaldu
Add option for choosing device from python
6e483e2
@sbaldu
Cleaning and formatting
5f6d317
@sbaldu
Remove unneeded boost submodule
8d59b4b
@sbaldu
Prepare compilation for AMD GPUs
4d490b3
@sbaldu
Update CLUEstering.py and Makefile
98e60ab
@sbaldu
Uncommenting other dimensions run functions
e88e23a
@sbaldu
Clean Makefile
cf59df8
@sbaldu
Add conditional compilation of modules and handling of import errors
778da30
@sbaldu
Formatting
67ddb8e
@sbaldu
Copy link
Collaborator Author

sbaldu commented Jan 18, 2024

Rebased on main after merge of PR #10

@waredjeb
Copy link
Collaborator

CI tests will be fixed in the next PR

@waredjeb waredjeb merged commit 9c19be3 into cms-patatrack:main Jan 19, 2024
15 of 20 checks passed
@sbaldu sbaldu deleted the feature_alpaka branch January 29, 2024 10:15
@sbaldu sbaldu mentioned this pull request Feb 6, 2024
Merged
@sbaldu sbaldu mentioned this pull request Mar 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicepantaleo felicepantaleo felicepantaleo left review comments

@waredjeb waredjeb waredjeb approved these changes

Assignees

@waredjeb waredjeb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbaldu @waredjeb @felicepantaleo @slanzi00