Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Python 3 compatibility #152

Merged
merged 39 commits into from
May 31, 2019
Merged

[WIP] Python 3 compatibility #152

merged 39 commits into from
May 31, 2019

Conversation

kreczko
Copy link
Member

@kreczko kreczko commented Aug 21, 2018

Fixes #151

@kreczko kreczko force-pushed the kreczko-issue-151 branch 5 times, most recently from 99740b0 to d564f06 Compare August 23, 2018 12:43
kreczko added 17 commits May 3, 2019 09:45
@kreczko
fixed get_l1Analysis for python 3
e5dc59e
@kreczko
Python 3 tests are no longer allowed to fail
6b45db6
@kreczko
itertools.izip --> six.moves.zip
dae20b4
@kreczko
urllib2 --> six.moves.urllib
c937292
@kreczko
No longer using "exceptions" module. All exceptions we use are define…
f64d30a 
…d in __builtins__
@kreczko
print --> print()
d05a9dd
@kreczko
fixed adding generator and list
34c5bd0
@kreczko
iteritems --> six.iteritems
3622f81
@kreczko
fixed imports (relative-explicit) for analyzers
e580840
@kreczko
fixed pep8: order of import
4c7a87f
@kreczko
ignore order for binning regions test
1d8e324
@kreczko
fixed _expand_lumi_ranges for python 3: generator --> list
6b4e530
@kreczko
dict.itervalues() --> six.itervalues(dict)
a2f6e8a
@kreczko
range + list --> list(range) + list
5954b8a
@kreczko
fixed double import in batch.common
9c91df1
@kreczko
fixed invalid syntax for import in HW_Emu_jetMet_rates
7e5ffee
@kreczko
get_l1analysis: file write mode "w" --> "wb"
0212b9b
@lgtm-com
Copy link

lgtm-com bot commented May 14, 2019

This pull request introduces 2 alerts and fixes 49 when merging c585126 into d8d343b - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Mismatch between signature and use of an overridden method

fixed alerts:

  • 41 for Unused import
  • 6 for Signature mismatch in overriding method
  • 2 for Unused local variable

Comment posted by LGTM.com

@lgtm-com
Copy link

lgtm-com bot commented May 15, 2019

This pull request fixes 49 alerts when merging 29a4aa8 into d8d343b - view on LGTM.com

fixed alerts:

  • 41 for Unused import
  • 6 for Signature mismatch in overriding method
  • 2 for Unused local variable

Comment posted by LGTM.com

@lgtm-com
Copy link

lgtm-com bot commented May 16, 2019

This pull request fixes 49 alerts when merging bbfad85 into d8d343b - view on LGTM.com

fixed alerts:

  • 41 for Unused import
  • 6 for Signature mismatch in overriding method
  • 2 for Unused local variable

Comment posted by LGTM.com

@kreczko kreczko changed the base branch from master to 0.6.x May 31, 2019 12:05
@kreczko kreczko changed the base branch from 0.6.x to dev May 31, 2019 12:07
@kreczko kreczko merged commit 91a459e into cms-l1t-offline:dev May 31, 2019
@kreczko kreczko deleted the kreczko-issue-151 branch May 31, 2019 12:08
@lgtm-com
Copy link

lgtm-com bot commented May 31, 2019

This pull request fixes 49 alerts when merging bbfad85 into 95c29f4 - view on LGTM.com

fixed alerts:

  • 41 for Unused import
  • 6 for Signature mismatch in overriding method
  • 2 for Unused local variable

Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kreczko