[For Review] Add Elasticsearch 5.3.3 #70
Open
+62
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgeorge
requested changes
Sep 6, 2017
|
|
||
| # Install Elasticsearch | ||
| # (Allows VM host access and enables CORS for all .vm hosts) | ||
| class { 'elasticsearch': |
There was a problem hiding this comment.
Two stylistic items here:
- Two Spaces instead of tabs, please: http://puppet-lint.com/checks/hard_tabs/
- Line up arrows under the config element: http://puppet-lint.com/checks/arrow_alignment/
There was a problem hiding this comment.
Additionally, rather than just adding Elasticsearch by default, I'd like to see it wrapped in a feature-switch. So, new object in config.rb, Vagrantfile and a new Fact, tracking enabled optional things. We can then use the same kind of functionality to optionally provision Solr, or optionally provision PML, or optionally provision in-box theme compilation tools.
I'd also like to see any optional things pulled into their own class in their own Puppet file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted for use and review in order to facilitate the ability for developers to begin building and evaluating Elasticsearch as a viable service and solution for some of our downstream projects.
Elasticsearch5.3.3(mirrors latest release on AWS) as a new service in PrecipModulefile(deprecated in Puppet 3.x, removed in 4.x) from theprecipPuppet modulemetadata.jsonto the precipPuppetmodule