Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm draft verify #134

Closed
wants to merge 8 commits into from
Closed

arm draft verify #134

wants to merge 8 commits into from

Conversation

clux
Copy link
Owner

@clux clux commented Feb 26, 2024

for #133

@clux
Copy link
Owner Author

clux commented Feb 26, 2024

hm, am i doing something wrong 🤔

# on mac after doing just build-stable-arm and testing with the arm64 test params
./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate
zsh: exec format error: ./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate

Signed-off-by: clux <[email protected]>
@eranrund
Copy link
Collaborator

hm, am i doing something wrong 🤔

# on mac after doing just build-stable-arm and testing with the arm64 test params
./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate
zsh: exec format error: ./test/plaincrate/target/aarch64-unknown-linux-musl/debug/plaincrate

I think that's expected - Mac can't run Linux binaries even if they're both ARM64.

@clux
Copy link
Owner Author

clux commented Feb 26, 2024

I guess that makes sense. Don't know why I expected that to work.

It's ultimately cloud environments where musl is most useful in arm land so not a big problem.

@eranrund
Copy link
Collaborator

Looks like this just passed CI - was there anything else you wanted to do here?

@clux
Copy link
Owner Author

clux commented Feb 27, 2024

I'll run a quick sanity tomorrow against an arm environment, but locally this looks good!

clux added a commit to kube-rs/controller-rs that referenced this pull request Feb 27, 2024
@clux
Copy link
Owner Author

clux commented Feb 27, 2024

@eranrund all good. have a full e2e in kube-rs/version-rs#93

(i did also struggle with using cargo run with --platform in kube-rs/controller-rs#67 where it bombs out, but that's probably something else - and i am happy that i can at least use the builder pattern)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants