-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm draft verify #134
arm draft verify #134
Conversation
…upports both x86_64 and arm64
Co-authored-by: Eirik A <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
hm, am i doing something wrong 🤔
|
Signed-off-by: clux <[email protected]>
I think that's expected - Mac can't run Linux binaries even if they're both ARM64. |
I guess that makes sense. Don't know why I expected that to work. It's ultimately cloud environments where musl is most useful in |
Looks like this just passed CI - was there anything else you wanted to do here? |
I'll run a quick sanity tomorrow against an arm environment, but locally this looks good! |
Signed-off-by: clux <[email protected]>
@eranrund all good. have a full e2e in kube-rs/version-rs#93 (i did also struggle with using cargo run with --platform in kube-rs/controller-rs#67 where it bombs out, but that's probably something else - and i am happy that i can at least use the builder pattern) |
for #133