Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer scripts #259

Closed
wants to merge 1 commit into from

Conversation

WendellAdriel
Copy link

This PR adds some composer scripts to make it easier for the contributors to remember how to run the needed commands for testing.

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label May 14, 2024
@SimonFrings
Copy link
Contributor

@WendellAdriel Thanks for contributing to Framework X 👍

This is generally a good idea to make the use of different commands easier and I see the value behind this, but I'm not sure if Framework X is the right project for this. We have many many Open Source libraries (similar to this one) and we try to create a consistent usage across all of them, so accepting this here would also open up the question if we should apply the same changes to our other projects. For some this even might be more work and I don't think there's much gained tbh.

This is more of a way to execute commands (tests, running server, etc.) differently and I don't really feel it's "better" than before. Don't get me wrong, the overall idea is good (we do the same with Makefiles), but in my opinion better suited for applications instead of libraries.

Nonetheless, thanks for bringing in your idea, keep em coming 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants