1194 listeners not showing up on private extractor branch #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The access object was not properly registered for non private extractors
tcnichol
requested review from
longshuicy,
max-zilla and
lmarini
as code owners
The access object was not properly registered for non private extractors
tcnichol
deleted the
1194-listeners-not-showing-up-on-private-extractor-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the db, the error is that when the heartbeat listener receives an extractor that is not private, the owner is "" (empty string) and not 'None' or 'null.' It seemed like the best way to fix this was by checking for that and then explicitly making the access field None.
To test this, run the dependencies using docker-dev.sh up, but then kill the container for the heartbeat_listener, and run it manually with this branch. Extractors should now register correctly if they are not private, and then they should show up correctly on the listeners page.