Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting active to it's original value for existing extractor #1153

Merged
merged 1 commit into from
Jul 24, 2024
Merged

setting active to it's original value for existing extractor #1153

merged 1 commit into from
Jul 24, 2024

Conversation

ddey2
Copy link
Member

@ddey2 ddey2 commented Jul 24, 2024

No description provided.

@ddey2 ddey2 requested a review from max-zilla as a code owner July 24, 2024 02:28
@ddey2 ddey2 linked an issue Jul 24, 2024 that may be closed by this pull request
Extractors disabled automatically on it's own after few minutes #1152
Closed
tcnichol
tcnichol approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it works. I'm marking approved.

@longshuicy
Copy link
Member

I notice below behavior:

  • When a dead extractor being enabled (see below) I can see it in the extractors under analysis tab
  • When this extractor become alive, it disappeared from the analysis tab as well as becomes disabled automatically
image

@lmarini lmarini merged commit 5ea5e46 into main Jul 24, 2024
6 checks passed
@lmarini lmarini deleted the 1152-extractors-disabled-automatically-on-its-own-after-few-minutes branch July 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarini lmarini lmarini approved these changes

@tcnichol tcnichol tcnichol approved these changes

@max-zilla max-zilla Awaiting requested review from max-zilla max-zilla is a code owner

@longshuicy longshuicy Awaiting requested review from longshuicy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extractors disabled automatically on it's own after few minutes
4 participants
@ddey2 @longshuicy @lmarini @tcnichol