fixed new docker versioning vs semantic_version #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahil Suneja <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 89.31% 89.34% +0.02%
==========================================
Files 111 111
Lines 4147 4157 +10
==========================================
+ Hits 3704 3714 +10
Misses 443 443
Continue to review full report at Codecov.
|
nadgowdas
reviewed
Mar 20, 2017
| def _fix_version(v): | ||
| # removing leading zeroes from docker version | ||
| # which are not liked by semantic_version | ||
| version_parts = re.match(r'(\d+).(\d+).(\d+)', v) |
There was a problem hiding this comment.
So essentially for docker version "17.04.01-ce", "17.04.01" would be compared against 1.10.0?
| @@ -44,6 +45,14 @@ def tearDown(self): | |||
|
|
|||
| shutil.rmtree(self.tempd) | |||
|
|
|||
| def test_fix_version(self): | |||
| import semantic_version | |||
| ver = u'17.03.01-ce' | |||
There was a problem hiding this comment.
can you also add a travis test for new docker version ?
nadgowdas
approved these changes
Mar 21, 2017
There was a problem hiding this comment.
As discussed with @sahilsuneja1 he will create a new PR to update travis configs to run testa against new docker version. Issue #267 opened to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sahil Suneja [email protected]
fix for #260