-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize the existence of external (read-only) stacks #618
Open
danielkza
wants to merge
10
commits into
cloudtools:master
Choose a base branch
from
Cobliteam:external-stacks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+455
−162
Commits on Mar 29, 2019
-
config: add simplified ExternalStack model
To import outputs from stacks that are not managed directly by a Stacker config and require custom settings (such as a profile or region), it was previously possible to just omit both a `class_path` and `template_path`. Make that pattern "official" by introducing an `external` option, and a simplified `ExternalStack` model that omits all the stack keys that do not make sense if we're never going to create/update the stack. Note: the upgrade to schematics 2.1.0 is required due to a bug [1] where polymorphic models were not properly validated. [1]: schematics/schematics#440
Configuration menu - View commit details
-
Copy full SHA for 8130fa6 - Browse repository at this point
Copy the full SHA 8130fa6View commit details -
Properly handle external stacks in actions
Don't ever attempt to update them, but always submit them so outputs can be grabbed.
Configuration menu - View commit details
-
Copy full SHA for 17ff01b - Browse repository at this point
Copy the full SHA 17ff01bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f614885 - Browse repository at this point
Copy the full SHA f614885View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc868ad - Browse repository at this point
Copy the full SHA fc868adView commit details -
Move should_update and should_submit methods to Stack subclasses
This makes handling the difference between managed and external stacks much easier. Also clean up the build tests a little bit by creating a TestStack class instead of using Mocks.
Configuration menu - View commit details
-
Copy full SHA for d0ee28e - Browse repository at this point
Copy the full SHA d0ee28eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19a0386 - Browse repository at this point
Copy the full SHA 19a0386View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a7e889 - Browse repository at this point
Copy the full SHA 9a7e889View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6978716 - Browse repository at this point
Copy the full SHA 6978716View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e36bf6 - Browse repository at this point
Copy the full SHA 8e36bf6View commit details
Commits on Apr 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2ce72e2 - Browse repository at this point
Copy the full SHA 2ce72e2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.