Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize the existence of external (read-only) stacks #618

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Commits on Mar 29, 2019

  1. config: add simplified ExternalStack model

    To import outputs from stacks that are not managed directly by a Stacker
    config and require custom settings (such as a profile or region), it was
    previously possible to just omit both a `class_path` and
    `template_path`.
    
    Make that pattern "official" by introducing an `external` option, and a
    simplified `ExternalStack` model that omits all the stack keys that do
    not make sense if we're never going to create/update the stack.
    
    Note: the upgrade to schematics 2.1.0 is required due to a bug [1] where
    polymorphic models were not properly validated.
    
    [1]: schematics/schematics#440
    danielkza committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    8130fa6 View commit details
    Browse the repository at this point in the history
  2. Properly handle external stacks in actions

    Don't ever attempt to update them, but always submit them so outputs can
    be grabbed.
    danielkza committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    17ff01b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f614885 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc868ad View commit details
    Browse the repository at this point in the history
  5. Move should_update and should_submit methods to Stack subclasses

    This makes handling the difference between managed and external stacks
    much easier.
    
    Also clean up the build tests a little bit by creating a TestStack class
    instead of using Mocks.
    danielkza committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    d0ee28e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    19a0386 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a7e889 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6978716 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8e36bf6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. Configuration menu
    Copy the full SHA
    2ce72e2 View commit details
    Browse the repository at this point in the history