Rework

cloudsufi · Jan 29, 2024 · 37869a0 · 37869a0
1 parent 3f2c1b6
commit 37869a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/main/java/io/cdap/plugin/successfactors/source/SuccessFactorsSource.java b/src/main/java/io/cdap/plugin/successfactors/source/SuccessFactorsSource.java
@@ -169,12 +169,9 @@ private void attachFieldWithError(SuccessFactorsServiceException ose, FailureCol
             failureCollector.addFailure(errMsg, null).
               withConfigProperty(SuccessFactorsConnectorConfig.ASSERTION_TOKEN);
           } else {
-            failureCollector.addFailure(errMsg, null).
-              withConfigProperty(SuccessFactorsConnectorConfig.PRIVATE_KEY);
-            failureCollector.addFailure(errMsg, null).
-              withConfigProperty(SuccessFactorsConnectorConfig.USER_ID);
-            failureCollector.addFailure(errMsg, null).
-              withConfigProperty(SuccessFactorsConnectorConfig.TOKEN_URL);
+            failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.PRIVATE_KEY);
+            failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.USER_ID);
+            failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.TOKEN_URL);
           }
         }
         break;

diff --git a/src/main/java/io/cdap/plugin/successfactors/source/transport/SuccessFactorsTransporter.java b/src/main/java/io/cdap/plugin/successfactors/source/transport/SuccessFactorsTransporter.java
@@ -121,10 +121,8 @@ public SuccessFactorsResponseContainer callSuccessFactorsWithRetry(URL endpoint)
    * @throws IOException if all retries fail
    */
   public Response retrySapTransportCall(URL endpoint, String mediaType) throws IOException {
-    AtomicInteger attemptCounter = new AtomicInteger(0);
     Callable<Boolean> fetchRecords = () -> {
       response = transport(endpoint, mediaType);
-      LOG.info("Response code in retry: {}", response.code());
       if (response != null && response.code() >= HttpURLConnection.HTTP_INTERNAL_ERROR) {
         throw new RetryableException();
       }