Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLUGIN-1723] Fix JavaScript Deciaml Values #14

Merged
merged 1 commit into from
May 22, 2024
Merged

[PLUGIN-1723] Fix JavaScript Deciaml Values #14

merged 1 commit into from
May 22, 2024

Conversation

psainics
Copy link
Collaborator

@psainics psainics commented Apr 24, 2024 •
edited
Loading

Fix JavaScript Deciaml Values

Jira : PLUGIN-1723

Description

When the output of the JS transform plugin is of Decimal data type, all the result records become null.

image

Code change

  • Modified JavaScriptTransform.java
    • Add case to handle decimal type.

Unit Tests

  • Modified JavaScriptTransformTest.java
    • Added Test testDecimalTransform
image

@psainics psainics added the bug Something isn't working label Apr 24, 2024
@psainics psainics self-assigned this Apr 24, 2024
@psainics psainics force-pushed the patch/js-decimal-bug branch 3 times, most recently from d5ae110 to 044257a Compare May 20, 2024 00:45
@AnkitCLI AnkitCLI merged commit 24775a2 into develop May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasrathee-cs vikasrathee-cs Awaiting requested review from vikasrathee-cs

Assignees

@psainics psainics

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psainics @AnkitCLI