fix flaky test (#79)

.github/workflows/build_and_test.yaml

@@ -9,7 +9,7 @@ jobs:
  runs-on: ubuntu-latest
  services:
  emulator:
- image: gcr.io/cloud-spanner-emulator/emulator:1.4.9
+ image: gcr.io/cloud-spanner-emulator/emulator:1.5.0
  ports:
  - 9010:9010
  - 9020:9020

pkg/spanner/client_test.go

@@ -63,6 +63,7 @@ const (
 )
 
 func TestLoadDDL(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  client, done := testClientWithDatabase(t, ctx)
@@ -84,6 +85,7 @@ func TestLoadDDL(t *testing.T) {
 }
 
 func TestApplyDDLFile(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  ddl, err := ioutil.ReadFile("testdata/ddl.sql")
@@ -127,6 +129,7 @@ func TestApplyDDLFile(t *testing.T) {
 }
 
 func TestApplyDMLFile(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  client, done := testClientWithDatabase(t, ctx)
@@ -200,6 +203,7 @@ func TestApplyDMLFile(t *testing.T) {
 }
 
 func TestExecuteMigrations(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  client, done := testClientWithDatabase(t, ctx)
@@ -297,6 +301,7 @@ func ensureMigrationVersionRecord(t *testing.T, ctx context.Context, client *Cli
 }
 
 func TestGetSchemaMigrationVersion(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  client, done := testClientWithDatabase(t, ctx)
@@ -330,6 +335,7 @@ func TestGetSchemaMigrationVersion(t *testing.T) {
 }
 
 func TestSetSchemaMigrationVersion(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  client, done := testClientWithDatabase(t, ctx)
@@ -359,6 +365,7 @@ func TestSetSchemaMigrationVersion(t *testing.T) {
 }
 
 func TestEnsureMigrationTable(t *testing.T) {
+ t.Parallel()
  ctx := context.Background()
 
  client, done := testClientWithDatabase(t, ctx)
@@ -403,6 +410,7 @@ func TestEnsureMigrationTable(t *testing.T) {
 }
 
 func TestPriorityPBOf(t *testing.T) {
+ t.Parallel()
  tests := map[string]struct {
  priority PriorityType
  want sppb.RequestOptions_Priority
@@ -453,7 +461,7 @@ func testClientWithDatabase(t *testing.T, ctx context.Context) (*Client, func())
 
  id := uuid.New()
  database := fmt.Sprintf("test-%s", id.String()[:18])
- fmt.Printf("database %v\n", database)
+ t.Logf("database %v\n", database)
 
  config := &Config{
  Project: project,
@@ -475,6 +483,14 @@ func testClientWithDatabase(t *testing.T, ctx context.Context) (*Client, func())
  t.Fatalf("failed to create database: %v", err)
  }
 
+ // Spanner emulator is unstable when using a connection before creating a database.
+ // So recreate a wrench client for reconnecting the emulator.
+ client.Close()
+ client, err = NewClient(ctx, config)
+ if err != nil {
+ t.Fatalf("failed to create spanner client: %v", err)
+ }
+
  return client, func() {
  defer client.Close()