fix constant diff in cloudsmith_manage_team #127
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
The only real change is to the
cloudsmith/resource_manage_team.go
file.This alters the
members
to a schema ofTypeSet
rather thanTypeList
which allows terraform to ignore the order of the sorted members.I tested this by running it against my Cloudsmith account, and all the relevant diffs were gone.
I also did multiple adding/deleting/updating of users into various teams, and terraform/Cloudsmith behaved correctly each time.
The
examples
files were updated as I run aterraform fmt
pre-commit git hook, and so the formatting is now correct.If this approved/merged, then could a new release be released, as this constant diff is really clouding our plans.
Update
Looks like some of the GHA tests failed:
provider_test.go:32: CLOUDSMITH_API_KEY must be set for acceptance tests
Secret `SLACK_WEBHOOK` is missing. Please add it to this action for proper execution
But not much I can do about that.