Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds findAllComponents selector #74

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Oct 24, 2024

Issue #, if available: Test utils API improvements project

Followed by: cloudscape-design/components#2932

Description of changes:

Adds findAllComponents selector. This selector is used in the components test utils to generate findAll[COMPONENT_NAME]s selectors.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (f49a5a9) to head (a386c1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   95.53%   95.75%   +0.22%     
==========================================
  Files           6        6              
  Lines         269      283      +14     
  Branches       59       65       +6     
==========================================
+ Hits          257      271      +14     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@orangevolon orangevolon force-pushed the alamiami/adds-find-all-components branch from 83a8ee1 to 771adf2 Compare October 29, 2024 08:55
@orangevolon orangevolon changed the title Alamiami/adds find all components feat: adds findAllComponents selector Oct 29, 2024
@orangevolon orangevolon marked this pull request as ready for review October 30, 2024 08:06
@orangevolon orangevolon requested a review from a team as a code owner October 30, 2024 08:06
@orangevolon orangevolon requested review from jperals and removed request for a team October 30, 2024 08:06
@orangevolon orangevolon force-pushed the alamiami/adds-find-all-components branch 2 times, most recently from 3586013 to 74f962f Compare November 4, 2024 09:29
jperals
jperals previously approved these changes Nov 6, 2024
src/core/test/dom.test.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants