fix: Remove act from selectors #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 93.60% 95.18% +1.57%
==========================================
Files 5 6 +1
Lines 266 270 +4
Branches 58 60 +2
==========================================
+ Hits 249 257 +8
+ Misses 17 12 -5
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
georgylobko
commented
Jul 31, 2024
scripts/verify-typescript.js
Outdated
| // Command-line API does not allow to use tsconfig when compiling only selected files | ||
| // https://github.com/microsoft/TypeScript/issues/27379 | ||
| execSync( | ||
| `tsc --noEmit --strict --experimentalDecorators --target es5 src/converter/test/inputs/converter/*.ts src/converter/test/outputs/converter/*.ts`, | ||
| `tsc --noEmit --strict --experimentalDecorators --target es5 ${includedInputFiles.join( |
There was a problem hiding this comment.
There is no built-in flag provided by tsc to easily exclude these files.
georgylobko
requested review from
avinashbot and
just-boris
and removed request for
a team
just-boris
reviewed
Jul 31, 2024
scripts/verify-typescript.js
Outdated
Comment on lines
12
to
14
| // These test files include utils represented as external dependencies to properly test their conversion to selectors. | ||
| // We need to skip them here because they are not expected to compile correctly. | ||
| const skip = ['strip-external-imports.ts']; |
There was a problem hiding this comment.
This change and everything else in this file seems like too much work to work around this issue.
Alternative options
- Can we make that code compile using
pathsortypeRootsoptions from tsconfig. - If fixing the typecheck is hard, can we put them into a separate
converter-no-typecheckfolder (seems easier than writing that much code to skip, right?)
There was a problem hiding this comment.
Option 2 looks like a way to go. Updated
just-boris
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.