Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add react to dependencies #63

Closed
wants to merge 1 commit into from

Conversation

NMVikings
Copy link

This commit introduced direct usage of React and react is not listed in dependencies. This can cause some consumers to fail because they may not have react as dependency, so they will have an error like

Error: Webpack Compilation Error
Module not found: Error: Can't resolve 'react'
Module not found: Error: Can't resolve 'react-dom/test-utils'

This happened with my integration tests. My commit should fix this issue.

Description of changes:

  • Add react to dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NMVikings NMVikings requested a review from a team as a code owner July 29, 2024 14:03
@NMVikings NMVikings requested review from Al-Dani and removed request for a team July 29, 2024 14:03
@NMVikings NMVikings changed the title Add react to dependencies fix: Add react to dependencies Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (c19106e) to head (beea145).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files           5        5           
  Lines         266      266           
  Branches       58       58           
=======================================
  Hits          249      249           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NMVikings NMVikings closed this Jul 29, 2024
@just-boris
Copy link
Member

As per our DM discussion, this package should not be used directly. The customer facing components package already contains the respective peerDependencies: https://github.com/cloudscape-design/components/blob/da2c8d191aedb6a34f4fc00f74fff670ad26aa72/package.json#L48-L51

Make sure you are using the latest npm version (8 or above is recommended) and this should resolve the issue for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants