-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Export act
from utils
#62
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 5 5
Lines 266 266
Branches 58 58
=======================================
Hits 249 249
Misses 17 17 ☔ View full report in Codecov by Sentry. |
Or you could export act from |
I considered this option, but decided to keep there, because |
Manipulating source code is more hacky operation than using a different file for import. One may also argue Line 70 in 7c63f39
|
act
from selectorsact
from utils
Issue #, if available:
Description of changes:
After exporting act from DOM utils, it turns out that after rewriting the import path from @cloudscape-design/.../dom to @cloudscape-design/.../selectors, act remains in the import statement, which is not expected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.