feat: Add merge utility #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 2 +1
Lines 15 28 +13
Branches 1 5 +4
=========================================
+ Hits 15 28 +13 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
merge-helper
branch
from
9cdc34c
to
4e56826
Compare
just-boris
commented
Mar 25, 2024
| @@ -6165,7 +6166,6 @@ | |||
| }, | |||
| "node_modules/lodash": { | |||
There was a problem hiding this comment.
Any real world project probably already has a dependency on lodash anyway, so this addition comes with no extra cost
cansuaa
reviewed
Mar 26, 2024
README.md
Outdated
| @@ -40,14 +40,14 @@ In your `jest.config.json`: | |||
|
|
|||
| ### Advanced usage | |||
|
|
|||
| If you are already have another preset in your configuration, you can [merge them together](https://stackoverflow.com/questions/51002460/is-it-possible-to-use-jest-with-multiple-presets-at-the-same-time): | |||
| If you are already have another preset in your configuration, you can use `@cloudscape-design/jest-preset/merge` helper to merge them together: | |||
There was a problem hiding this comment.
I know it isn't newly added but isn't the text supposed to be "If you already have another preset ..."?
just-boris
force-pushed
the
merge-helper
branch
from
4e56826
to
0b3bfbe
Compare
cansuaa
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding an extra built-in utility instead of relying on external dependency. See the updated readme for use-case example
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.