Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coalesce policy attachments to '/' #51

Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix: coalesce policy attachments to '/' #51

merged 3 commits into from
Nov 2, 2023

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Nov 1, 2023 •
edited
Loading

what

  • coalesce policy attachments in parameter-set module to "/"

why

  • Some versions of the aws-sso provider allow this behavior and it corrupts
    tfstate
  • coalesce is more friendly to generated paths, which could be difficult to correct in some scenarios

@dudymas dudymas requested review from a team as code owners November 1, 2023 21:46
@dudymas dudymas requested review from nitrocode and woz5999 November 1, 2023 21:46
@dudymas
Copy link
Contributor Author

dudymas commented Nov 1, 2023

/terratest

@dudymas dudymas changed the title fix: validate policy attachments have valid paths fix: coalesce policy attachments to '/' Nov 1, 2023
@dudymas dudymas merged commit a4148ec into main Nov 2, 2023
9 checks passed
@dudymas dudymas deleted the fix/permission-sets/disallow-empty-paths branch November 2, 2023 06:45
tschmidty69 added a commit to tschmidty69/terraform-aws-sso that referenced this pull request Dec 1, 2023
@tschmidty69
Merge pull request #1 from cloudposse/main
2d64645 
fix: coalesce policy attachments to '/' (cloudposse#51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudymas @Nuru