Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redeployment_trigger: replace timestamp() with plantimestamp() #251

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix: redeployment_trigger: replace timestamp() with plantimestamp() #251

merged 3 commits into from
Oct 8, 2024

Conversation

mslipets
Copy link
Contributor

REF: hashicorp/terraform-provider-aws#28070

what

in attempt to fix apply time issues like #28070,
replace usage of function timestamp() with plantimestamp()

why

provided function apparently works for use cases when redeploy_on_apply && force_new_deployment set to true

references

@mslipets mslipets requested review from a team as code owners September 26, 2024 13:08
@mergify mergify bot added the triage Needs triage label Sep 26, 2024
@mslipets
Copy link
Contributor Author

/terratest

@RoseSecurity
Copy link
Member

/terratest

@RoseSecurity
Copy link
Member

/terratest

RoseSecurity
RoseSecurity approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for this contribution and bug fix!

@RoseSecurity RoseSecurity merged commit 047ba2d into cloudposse:main Oct 8, 2024
15 checks passed
@mergify mergify bot removed the triage Needs triage label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

These changes were released in v0.76.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoseSecurity RoseSecurity RoseSecurity approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslipets @RoseSecurity