-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overriding default origin ID #264
base: main
Are you sure you want to change the base?
Conversation
/terratest |
Thanks @mchristopher for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
/terratest |
Hey @mchristopher, unfortunately, we need to run some automation to pass our tests. Mind doing the following locally, adding + committing the result, and pushing to your branch?
Thanks! |
And actually it seems there is some lint errors in this repo overall, would you mind addressing those to move this PR forward? |
what
default_origin_id
variable, to support custom origin groups on the default behavior.group_id
variable to origin_groups to avoid race conditions when specifying origin groups in behaviors.why
id
attributes outside of the module code.references