Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator/portal] Add path parameter for backends #152

Merged
merged 6 commits into from
Sep 4, 2018
Merged

[incubator/portal] Add path parameter for backends #152

merged 6 commits into from
Sep 4, 2018

Conversation

osterman
Copy link
Member

@osterman osterman commented Aug 4, 2018 •
edited
Loading

what

  • add path parameter

why

  • Certain services (kibana on elasticsearch) are not found on /

demo

image

references

#151

@osterman osterman requested review from goruha and aknysh August 5, 2018 06:15
@osterman osterman mentioned this pull request Aug 5, 2018
Merged
@osterman
Copy link
Member Author

osterman commented Aug 5, 2018

Wanted by cloudposse/helmfiles#14

@osterman osterman self-assigned this Aug 5, 2018
@osterman osterman added the wip label Aug 6, 2018
@osterman
Copy link
Member Author

osterman commented Aug 6, 2018

Also, I tried creating a centralized auth endpoint, but it's not supported by bitly oauth2.

bitly/oauth2_proxy#400 (comment)
bitly/oauth2_proxy#461
bitly/oauth2_proxy#490
bitly/oauth2_proxy#427
helm/charts#4452

@goruha goruha merged commit bcce24e into master Sep 4, 2018
@goruha goruha deleted the fix/gh151/portal-url-paths branch September 4, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@goruha goruha goruha approved these changes

Assignees

@osterman osterman

Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osterman @goruha @aknysh