Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly scope Docker build flags for build-harness project #370

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Properly scope Docker build flags for build-harness project #370

merged 1 commit into from
Jan 26, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jan 26, 2024

what

  • Scope default setting of DOCKER_BUILD_FLAGS to the build-harness project only

why

  • Bug introduced in Docker build fixes #369: Setting DOCKER_BUILD_FLAGS where it did affects all projects using build-harness, which includes most people's custom Geodesic images. It was intended to only affect the build of build-harness images.

@Nuru Nuru added bug Something isn't working bugfix Change that restores intended behavior auto-readme-disabled labels Jan 26, 2024
@Nuru Nuru requested a review from a team as a code owner January 26, 2024 23:19
@Nuru Nuru merged commit f2a5f44 into master Jan 26, 2024
13 checks passed
@Nuru Nuru deleted the revert-arch-force branch January 26, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

@osterman osterman Awaiting requested review from osterman

Assignees

@Nuru Nuru

Labels
auto-readme-disabled bug Something isn't working bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nuru