Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme Improvements #361

Merged
merged 23 commits into from
Nov 14, 2023
Merged

Readme Improvements #361

merged 23 commits into from
Nov 14, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Oct 26, 2023 •
edited
Loading

what

  • Update README template with latest preferences
  • Do not run auto-readme if modules/readme label
  • Change auto-readme to trigger on pull_request

why

  • Remove unnecessary sections and reorganize README template that is used to populate all cloud posse repos
  • Update the README with the PR intentionally
  • pull_request_target does not support labels; pull_request does.

references

@milldr milldr marked this pull request as ready for review October 27, 2023 00:33
@milldr milldr requested review from a team as code owners October 27, 2023 00:33
@milldr milldr merged commit 8b2a1cd into master Nov 14, 2023
14 of 15 checks passed
@milldr milldr deleted the readme-improvements branch November 14, 2023 21:50
@milldr milldr mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
auto-readme-disabled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milldr @osterman @cloudpossebot