Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not round up percentages #15

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: do not round up percentages #15

merged 1 commit into from
Nov 1, 2024

Conversation

mnencia
Copy link
Member

@mnencia mnencia commented Oct 25, 2024

Sometimes, the report contains lines like the following

  • 🟢 - local: 100.0% success. (3 out of 7151 tests failed)

It is weird to see failures when the percentage says 100% success.

This patch fixes the issue by always rounding down the success percentage to the first decimal.

Signed-off-by: Marco Nenciarini <[email protected]>
@jsilvela jsilvela merged commit b89eef6 into main Nov 1, 2024
6 checks passed
@mnencia mnencia deleted the dev/no_round branch November 7, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants