feat: create a test thermometer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Niccolò Fei <[email protected]>
Signed-off-by: Niccolò Fei <[email protected]>
NiccoloFei
approved these changes
Jun 4, 2024
jsilvela
commented
Jun 4, 2024
summarize_test_results.py
Outdated
| """ | ||
|
|
||
| output = f"{metric_name(metric)} thermometer:\n\n" | ||
| for bucket_hits in summary[metric]["failed"].items(): |
There was a problem hiding this comment.
We just found a bug here, when @NiccoloFei ran a CI/CD workflow with this branch (latest SHA)
https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9369542163
Since we iterate over the summary[metric]["failed"], we will skip over items that had no failures.
We should still get a printout even if there were zero failures.
Proboably better iterate over summary[metric]["total"]
@jlong49
Signed-off-by: John Long <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
jlong49
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output that can be used in chatops
Closes #9