Skip to content

Commit

Permalink
chore: nits
Browse files Browse the repository at this point in the history
Signed-off-by: Jaime Silvela <[email protected]>
  • Loading branch information
jsilvela committed May 31, 2024
1 parent 8ddbba8 commit 1efaaef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ Up to three outputs might be produced:
- `thermometer`: this will contain stand-alone text with a color-coded list
of test metrics that can serve as an overview of the state of the test suite
on CI/CD. This is generated on every execution of Ciclops.
It is *always* generated.

- `alerts`: this will contain stand-alone text with systematic failures
detected by CIclops. It is meant to enable further steps in the calling
Expand Down Expand Up @@ -106,7 +105,8 @@ There are two advanced cases we want to call attention to:
color-coded overview of the test health. This thermometer is included in
the GitHub summary, and in addition, is exported as an output in plain
text, which can be sent via chatops.
In addition, Ciclops will create a series of alerts when systematic failures are detected.
In addition, Ciclops will create a series of alerts when systematic failures
are detected.
By "systematic", we mean cases such as:

- all test combinations have failed
Expand Down
1 change: 1 addition & 0 deletions summarize_test_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,7 @@ def format_thermometer(summary, embed=True, file_out=None):
"""

output = ""
# we only test the "by_platform" metric for the thermometer, at the moment
for metric in ["by_platform"]:
output += compute_thermometer_on_metric(summary, metric, embed)

Expand Down

0 comments on commit 1efaaef

Please sign in to comment.