Make container securityContext optional for OpenShift compatibility #445
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new boolean flag enableSecurityContext within containerSecurityContext in values.yaml. This flag allows users to control whether the container-level securityContext should be included in the deployment. By default, it's set to true to maintain existing functionality. Signed-off-by: BlueCog <[email protected]>
…ityContext Modified the deployment.yaml template to include the container securityContext only when enableSecurityContext is true. This change makes the inclusion of the container-level securityContext conditional, providing flexibility for environments like OpenShift where specifying these fields may cause conflicts. Signed-off-by: BlueCog <[email protected]>
…urityContext setting Signed-off-by: BlueCog <[email protected]>
BlueCog
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
itay-grudev
added
the
chart( operator )
|
@sxd I yield here to your opinion for review/approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request adds a new configuration option to make the container-level securityContext optional in the CloudNativePG Helm chart. This change improves compatibility with OpenShift by allowing users to disable the container
securityContextwhen deploying the operator.Background:
When deploying the CloudNativePG operator on OpenShift, the predefined container
securityContextcan cause conflicts due to OpenShift's strict security policies. OpenShift manages user and group IDs dynamically and does not allow containers to run as a specific user or group unless explicitly permitted. HardcodedrunAsUserandrunAsGroupvalues (values.yaml) in the container securityContext may prevent pods from starting on OpenShift clusters.Changes Introduced:
enableSecurityContextundercontainerSecurityContextinvalues.yaml, defaulting totrueto maintain existing behavior.deployment.yamlto include the containersecurityContextonly whenenableSecurityContextis set totrue.README.mdto document the new configuration option and guide users on how to use it.Benefits:
Usage Example:
To disable the container
securityContexton OpenShift, setenableSecurityContexttofalsein your custom values/override file:Testing: