Fix ArgoCD diff on postgresql keys

[bozorgmehr96]

Use with for every key in the cluster's spec.postgresql to prevent generating empty keys.

Fixes: #426

[bozorgmehr96]

If there are other problems like this, give me the key names, and I will fix them.

[pschichtel]

@bozorgmehr96 this is my ignoreDifferences rule:

group: postgresql.cnpg.io
kind: Cluster
jsonPointers:
- /spec/bootstrap/initdb/postInitApplicationSQL
- /spec/managed
- /spec/postgresql/shared_preload_libraries
- /spec/priorityClassName
- /spec/postgresql/pg_hba
- /spec/postgresql/pg_ident

You covered the last two for me

[bozorgmehr96]

@pschichtel Thanks. I wrapped them in if blocks.

[pschichtel]

@bozorgmehr96 one more:

charts/charts/cluster/templates/scheduled-backups.yaml

Line 13 in fb45e4f

method: {{ .method }}

[bozorgmehr96]

@pschichtel, can you provide a repro? It has a non-empty default value, so it shouldn't have the problem I'm trying to fix here.

[pschichtel]

@bozorgmehr96 I customized the schedule, so I don't get the defaults since it's an array. According to

charts/charts/cloudnative-pg/templates/crds/crds.yaml

Line 15655 in fb45e4f

required:

and

charts/charts/cloudnative-pg/templates/crds/crds.yaml

Line 15575 in fb45e4f

default: barmanObjectStore

the method field is not required

[Stevenpc3]

I am getting a few items in argocd that are oddly just missing on the live manifest. Not sure if it's the CRD/operator or something with values that might be false by default removed or if these values don't exist anymore?

• bypassrls
• createrole
• replication
• superuser

There might be more since we didn't set them all.

Here are other issues just to list them all. Some are shown in other places.

I think the issue is clearly the operator doesn't generate these empty or default values in the spec it creates.